fix: honor per-type ShallowCopyForSameType override (#938)#975
Closed
leno23 wants to merge 1 commit into
Closed
Conversation
Resolve ShallowCopyForSameType from merged settings for same-type member adaptation so a parent mapping's deep-copy override does not suppress global shallow-copy behavior on nested same-type members, while explicit per-type false overrides still force deep copy for self-mappings. Co-authored-by: Cursor <cursoragent@cursor.com>
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ShallowCopyForSameTypefrom merged per-type settings when adapting same-type members, instead of always using the parent mapping's settings.ShallowCopyForSameType(false)no longer suppresses global shallow-copy behavior for nested implicit same-type members.ShallowCopyForSameType(false)overrides still force deep copy for self-mappings, including MapToTarget restore scenarios with ctor-initialized nested properties.Root cause
CreateAdaptExpressioncheckedarg.Settings.ShallowCopyForSameTypefrom the enclosing mapping context. When a parent type opted into deep copy, nested same-type members incorrectly inherited that setting even when their own merged settings/default should remain shallow.Test plan
WhenPerTypeShallowCopyOverride.GlobalShallowCopy_WithPerTypeDeepCopy_ShouldRestoreViaMapToTargetWhenPerTypeShallowCopyOverride.ParentDeepCopyOverride_ShouldNotDisableImplicitNestedShallowCopyForSameTypeWhenConfiguringMappingshallow-copy tests pass